Remove uneeded cd for unit #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of unit tests we were previously changing the directory to the collection directory within the tox venv.
Since the tests are being run by pytest, collection adjaceny is not considered. The pytest command issued runs the tests from the source tree and not the installed collection.
The pytest-ansible plugin is taking care of the injection of ANSIBLE_COLLECTIONS_PATH into ansible.
Remove the cd command for unit, this has the added benefit of cleaning up the test names in the pytest output since the working directory is no longer relative to actual tests.
Tested locally