Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert pip upgrade #334

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Revert pip upgrade #334

merged 1 commit into from
Jun 14, 2024

Conversation

cidrblock
Copy link
Collaborator

This reverts #333. commands_pre runs after the deps are installed and the deps require a current version of pip.

tos facilitates this already, (TIL). It has the ability to download pip rather than use the wheel.

tox-ansible.ini

[testenv]
download = true

is all that is needed.

example

integration-py3.12-2.16: 10494 D download wheel pip 3.12 to /root/.local/share/virtualenv/wheel/house [virtualenv/seed/wheels/acquire.py:53]

@cidrblock cidrblock requested a review from a team as a code owner June 14, 2024 13:09
@cidrblock cidrblock requested review from ssbarnea and Qalthos and removed request for a team June 14, 2024 13:09
@github-actions github-actions bot added the bug This issue/PR relates to a bug. label Jun 14, 2024
@cidrblock cidrblock merged commit a83a006 into ansible:main Jun 14, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cidrblock