Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional tests #356

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add additional tests #356

merged 1 commit into from
Jul 29, 2024

Conversation

cidrblock
Copy link
Collaborator

  • Clean up some exisiting tests to not use shell=True
  • Switch one test from integration to unit
  • Remove use of runpy modules since it was polluting tox internals
  • Add unit tests to cover some lines not previously covered

@cidrblock cidrblock requested a review from a team as a code owner July 29, 2024 18:52
@cidrblock cidrblock requested review from ssbarnea and alisonlhart and removed request for a team July 29, 2024 18:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added the skip-changelog Can be missed from the changelog. label Jul 29, 2024
@cidrblock cidrblock merged commit 94d5dae into ansible:main Jul 29, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@alisonlhart alisonlhart Awaiting requested review from alisonlhart alisonlhart is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii

Assignees
No one assigned
Labels
skip-changelog Can be missed from the changelog.
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cidrblock