fix: replace cp --parents with rsync for macOS compatibility
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3nryc0ding
requested review from
Qalthos and
alisonlhart
and removed request for
a team
|
Hi @cidrblock , could you please provide feedback on this PR? I'm blocked until it's merged and would appreciate your input. Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #246
Summary
Replaced the use of
cp --parentswithrsync -rto ensure compatibility with macOS, avoiding the need to install the GNU version ofcp.Details
To verify this change, I ran a minimal example using both
cpandrsync:cponmacos-latestandubuntu-latest: GitHub Action runrsynconmacos-latestandubuntu-latest: GitHub Action runNote
The test setup intentionally causes all integration tests to fail while ensuring unit tests succeed. This confirms that the tests are executing correctly as expected.