Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent venv initialization error with py39 #396

Merged
merged 1 commit into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/tox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.entry.python }}
# tox-ansible requires python 3.10 but it can be used to test with
# older versions of python.
python-version: |
${{ matrix.entry.python }}
3.10

- name: Install tox-ansible, includes tox
run: python3 -m pip install .
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ allow-init-docstring = true
arg-type-hints-in-docstring = false
baseline = ".config/pydoclint-baseline.txt"
check-return-types = false
exclude = '\.eggs|\.git|\.tox|build|out|venv'
exclude = '\.cache|\.eggs|\.git|\.mypy_cache|\.tox|build|dist|out|venv'
should-document-private-class-attributes = true
show-filenames-in-every-violation-message = true
skip-checking-short-docstrings = false
Expand Down
8 changes: 5 additions & 3 deletions src/tox_ansible/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@
{integration, sanity, unit}-py3.13-{2.18, milestone, devel}
"""
TOX_WORK_DIR = Path()
# Without the minimal pytest-ansible condition, installation may fail in some
# cases (pip, uv).
OUR_DEPS = [
"pytest",
"pytest-xdist",
"pytest-ansible",
"pytest>=7.4.3", # Oct 2023
"pytest-xdist>=3.4.0", # Nov 2023
"pytest-ansible>=v4.1.1", # latest version still supporting py39 (Oct 2023)
]

T = TypeVar("T", bound=ConfigSet)
Expand Down