Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eclipse Che APB #24

Merged
1 commit merged into from
Sep 6, 2018
Merged

Update Eclipse Che APB #24

1 commit merged into from
Sep 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2018

What does this PR do?

  1. Add TLS support. Depending on user choice, secure or non secure routes are created. Also, Che server config map is edited accordingly
  2. Add support of self signed certs. Content of a cert is provided by a user in the UI. Then the cert is saved to a secret and referenced in env for Che server and Keycloak. Entrypoints of both deployments act accordingly
  3. Add support of using external Keycloak and/or Postgres. Since conditional textfields are not yet available (Add parsing of param dependencies openshift/ansible-service-broker#928) currently, I cannot hide fields and checkboxes depending on a user's choice. Can be improved with 3.11 out. Tested with external Keycloak/Red Hat SSO instance and a postgres provisioned in the same cluster in a dedicated namespace. For an external Keycloak, there are two modes: provision realm, client and user, or use an existing realm and client.
  4. Remove unused tasks. There were a lot of unused tasks since the APB was built from existing Keycloak and Postgres APBs. Only tasks that are actually called are left. This makes APB yamls easier to read and understand.
  5. Remove Keycloak IS - not sure I understand why this is the only deployment that uses it
  6. Remove everything related to creating https route for Keycloak and then deleting it. Checking if Keycloak is available can be accomplished in a cleaner way.
  7. Removed ifs with ephemeral plan id. Currently, it is not possible to deploy Che multiuser with H2 database.
  8. Removed unnecessary Postgres deployment yamls from Keycloak APB - probably leftovers from the original independent Keycloak APB
  9. Make Keycloak client id and realm really configurable (in json templates).

@ghost ghost force-pushed the unpaded_eclipse_che_apb branch from 001080f to 3ad5db0 Compare September 4, 2018 15:43
@ibuziuk ibuziuk mentioned this pull request Sep 4, 2018
@ghost ghost force-pushed the unpaded_eclipse_che_apb branch from 7c1f151 to 73c061e Compare September 5, 2018 08:26
@ghost ghost closed this Sep 5, 2018
@ghost ghost reopened this Sep 5, 2018
@ghost ghost force-pushed the unpaded_eclipse_che_apb branch from 69e14db to 98799d2 Compare September 5, 2018 13:39
@ghost ghost requested a review from l0rd September 5, 2018 14:17
@ghost ghost merged commit cf4dbb2 into master Sep 6, 2018
@ghost ghost deleted the unpaded_eclipse_che_apb branch September 6, 2018 10:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant