Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename GeomPlotter to GeometryPlotter #1227

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

RobPasMue
Copy link
Member

Description

Renaming plotter class name

Issue linked

No issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this May 30, 2024
@RobPasMue RobPasMue requested review from PipKat and a team as code owners May 30, 2024 06:16
@RobPasMue RobPasMue requested a review from MaxJPRey May 30, 2024 06:17
@github-actions github-actions bot added the enhancement New features or code improvements label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (2722049) to head (d283975).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          85       85           
  Lines        6554     6554           
=======================================
  Hits         6042     6042           
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit b66b1c6 into main May 30, 2024
46 checks passed
@RobPasMue RobPasMue deleted the feat/rename-plotter branch May 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants