-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add misc. repair and prepare tool methods #1293
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 92.03% 91.92% -0.11%
==========================================
Files 86 86
Lines 6713 6759 +46
==========================================
+ Hits 6178 6213 +35
- Misses 535 546 +11 ☔ View full report in Codecov by Sentry. |
… feat/bdickens/repair-prepare-workflow06
…hub.com/ansys/pyansys-geometry into feat/bdickens/repair-prepare-workflow06 # Conflicts: # src/ansys/geometry/core/tools/prepare_tools.py Fix merge conflict re: headers
Grammar, phrasing, and convention cleanup of comments Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
I've been out on a trip until today. Let me work on this today morning - sorry for the delay. @umutsoysalansys brings a good point though. Tests have to be added. |
@ansbdickens - please test my changes. They should work and simplify your PR |
@umutsoysalansys - I am reverting your changes. They broke lots of things in the process... |
1a2d919
to
c4f083c
Compare
HI @umutsoysalansys - something is wrong with this test: def test_fix_extra_edge(modeler: Modeler):
"""Test to find and fix extra edge problem areas."""
skip_if_linux(modeler, test_fix_extra_edge.__name__, "repair_tools") # Skip test on Linux
design = modeler.open_file(FILES_DIR / "ExtraEdgesDesignBefore.scdocx")
problem_areas = modeler.repair_tools.find_extra_edges(design.bodies)
assert problem_areas[0].fix().success is True Assert is throwing back False is True which means that the problem_areas are not being fixed. Can you look into it? |
@RobPasMue, I don't think there is anything wrong or different for this test and it is passing locally on Discovery but getting error on headless with this "Not fully implemented in Parasolid" remark. |
As long as it doesn't pass on the Geometry Service @umutsoysalansys we cannot merge it. Could you solve this on the server implementation? |
@RobPasMue yeah I can look into it, meanwhile you can stash that piece of the PR to somewhere else and merge the working parts? |
Sure, we can do that - I will completely skip the test. I will open a GH issue and assign it to you to solve this problem |
Description
Add PrepareTools and PrepareTools.share_topology method for list of bodies
Add ExtraEdgeProblemArea.fix() method
Add RepairTools.find_short_edges and ShortEdgeProblemArea
Issue linked
Exposes necessary components of a pyansys repair/prepare workflow
Checklist
feat: extrude circle to cylinder
)