Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable ruff formatter on pre-commit #1312

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

RobPasMue
Copy link
Member

Description

I completely forgot to enable the formatter on #1272... even though I ran it the first time 😄

Issue linked

Related to #1272

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jul 17, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner July 17, 2024 07:38
@github-actions github-actions bot added testing Anything related to tests maintenance Package and maintenance related labels Jul 17, 2024
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Jul 17, 2024
@RobPasMue RobPasMue enabled auto-merge (squash) July 17, 2024 07:42
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.01%. Comparing base (e78525e) to head (252cb69).

Files Patch % Lines
src/ansys/geometry/core/designer/body.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          86       86           
  Lines        6660     6660           
=======================================
  Hits         6128     6128           
  Misses        532      532           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 646db2d into main Jul 17, 2024
42 checks passed
@RobPasMue RobPasMue deleted the maint/enable-ruff-formatter branch July 17, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants