feat: driving dimensions

[umutsoysalansys]

Description

Bringing driving dimensions/ geometry parametrization to pyansys-geometry.

Issue linked

Checklist

• I have tested my changes locally.
• I have added necessary documentation or updated existing documentation.
• I have followed the coding style guidelines of this project.
• I have added appropriate unit tests.
• I have reviewed my changes before submitting this pull request.
• I have linked the issue or issues that are solved to the PR if any.
• I have assigned this PR to myself.
• I have added the minimum version decorator to any new backend method implemented.
• I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

[codecov]

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.68%. Comparing base (b1d6271) to head (0fae95a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ansys/geometry/core/parameters/parameters.py	73.68%	10 Missing ⚠️
src/ansys/geometry/core/designer/design.py	71.42%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   91.84%   91.68%   -0.16%     
==========================================
  Files          86       88       +2     
  Lines        6928     6988      +60     
==========================================
+ Hits         6363     6407      +44     
- Misses        565      581      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RobPasMue]

Let's discuss this later @umutsoysalansys but I wouldn't have it as an independent module of the whole "design" structure. I think driving dimensions should be a property of bodies...

[RobPasMue]

Overall looks good @umutsoysalansys! I left some enhancement suggestions. Main missing point is an example. We need examples that demonstrates how to use these new features. This is part of the requested actions for any new implementation. Otherwise users won't know how to make use of it.

[RobPasMue]

Seems like the test is failing - do you know the reason? There seems to be some kind of issue with the server apparently... We are using the latest proto and servers to check this so... maybe a pending PR on the server side?

[RobPasMue]

Blocking merge until comments are solved/implemented and the example is added. Also, testing needs to pass.

[PipKat]

Reviewed doc only to ensure it meets the PyAnsys style guidelines

[PipKat]

Style guidelines say to use "you" rather than "we" as you are addressing the reader.

________________________________ From: Umut Soysal ***@***.***> Sent: Wednesday, October 23, 2024 1:12 PM To: ansys/pyansys-geometry ***@***.***> Cc: Kathy Pippert ***@***.***>; Mention ***@***.***> Subject: Re: [ansys/pyansys-geometry] feat: driving dimensions (PR #1340) [External Sender] @umutsoysalansys commented on this pull request.

________________________________ In doc/source/examples/03_modeling/design_parameters.mystnb<#1340 (comment)>:

+jupytext:

+ text_representation: + extension: .mystnb + format_name: myst + format_version: 0.13 + jupytext_version: 1.16.4 +kernelspec: + display_name: Python 3 (ipykernel) + language: python + name: python3 +--- + +# Modeling: Using Design Parameters + +You can read and update parameters that are part of the design. +In this example, we have a simple design with two associated parameters. Thanks for the reviews @PipKat<https://github.com/PipKat>, I used "we" based on the previous examples on this examples section, so maybe they need to be corrected as well? thanks https://github.com/ansys/pyansys-geometry/blob/150c19b9dabe92e999262f89233970efc5c6c96a/doc/source/examples/01_getting_started/05_plotter_picker.mystnb#L177C23-L177C30 — Reply to this email directly, view it on GitHub<#1340 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUHQY26UBZQP3CF4TVJKWEDZ47KIDAVCNFSM6AAAAABL46RXW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBZGQ4DKNJXGE>. You are receiving this because you were mentioned.Message ID: ***@***.***>