-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use service colors in plotter (upon request) #1376
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
+ Coverage 91.87% 91.89% +0.02%
==========================================
Files 86 86
Lines 6790 6810 +20
==========================================
+ Hits 6238 6258 +20
Misses 552 552 ☔ View full report in Codecov by Sentry. |
…ansys/pyansys-geometry into feat/use-body-colors-in-plotter
Hi @PipKat - would you be able to review at least the |
This PR is expected to fail certain tests (at least until the new server version is available with the "null" return for colors whenever it is not assigned. |
Description
Enabling the usage of service colors upon request. Including a new library global variable called
ansys.geometry.core.USE_SERVICE_COLORS
. If set toTrue
the plotter will make use of the service-defined colors. This can make large components to be plotted very slowly since it will require interaction with the service. By default, SC green will be used, just like until now.We are also exposing these capabilities now via the
plot(...)
methods. Users won't have to specifically set the global variable if they just want to check it once.Documentation and testing has been added.
Issue linked
Closes #433
Checklist
feat: extrude circle to cylinder
)