Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use service colors in plotter (upon request) #1376

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Aug 27, 2024

Description

Enabling the usage of service colors upon request. Including a new library global variable called ansys.geometry.core.USE_SERVICE_COLORS. If set to True the plotter will make use of the service-defined colors. This can make large components to be plotted very slowly since it will require interaction with the service. By default, SC green will be used, just like until now.

We are also exposing these capabilities now via the plot(...) methods. Users won't have to specifically set the global variable if they just want to check it once.

Documentation and testing has been added.

Issue linked

Closes #433

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 27, 2024
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (8af9de9) to head (c55ca71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   91.87%   91.89%   +0.02%     
==========================================
  Files          86       86              
  Lines        6790     6810      +20     
==========================================
+ Hits         6238     6258      +20     
  Misses        552      552              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review August 28, 2024 14:25
@RobPasMue RobPasMue requested review from PipKat and a team as code owners August 28, 2024 14:25
@RobPasMue
Copy link
Member Author

Hi @PipKat - would you be able to review at least the mystnb file that contains the example I've worked on? Much appreciated!!

@RobPasMue
Copy link
Member Author

This PR is expected to fail certain tests (at least until the new server version is available with the "null" return for colors whenever it is not assigned.

@RobPasMue RobPasMue linked an issue Aug 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add color support on the Linux service PLOTTING: color alignment with service(Discovery,SpaceClaim)
2 participants