fix: Add default dict to run_discovery_script_file
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobPasMue
requested changes
Dec 4, 2023
|
Also, please link properly the issue to the PR so that it closes whenever it's merged |
RobPasMue
reviewed
Dec 4, 2023
RobPasMue
requested changes
Dec 4, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 83 83
Lines 5915 5915
=======================================
Hits 5443 5443
Misses 472 472 ☔ View full report in Codecov by Sentry. |
RobPasMue
requested changes
Dec 4, 2023
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
|
FYI - pre-commit failing. Please fix. Also, I know the linux part is not passing. Dev team is working on it. |
RobPasMue
approved these changes
Dec 4, 2023
RobPasMue
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults
script_argsto{}.Closes #870