Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt to ansys-visualizer #959

Merged
merged 52 commits into from
May 28, 2024
Merged

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jan 29, 2024

Extracts some common code from the plotter that can be reused in other projects. Extracted code goes to https://github.com/ansys-internal/pyansys-visualizer

Missing:

  • Move tests to other repo and adapt the tests that stay in this repo

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 29, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 14, 2024
@AlejandroFernandezLuces
Copy link
Contributor Author

Self reminder: Pyansys visualizer needs to be public before merging this

@RobPasMue
Copy link
Member

@AlejandroFernandezLuces - we need to get this working again

@github-actions github-actions bot removed the maintenance Package and maintenance related label May 22, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label May 22, 2024
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review May 27, 2024 14:58
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Just two small comments before approving

.github/workflows/nightly_docker_test.yml Show resolved Hide resolved
src/ansys/geometry/core/designer/body.py Outdated Show resolved Hide resolved
RobPasMue
RobPasMue previously approved these changes May 28, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments - otherwise LGTM

src/ansys/geometry/core/plotting/plotter.py Outdated Show resolved Hide resolved
@AlejandroFernandezLuces AlejandroFernandezLuces merged commit c68dc15 into main May 28, 2024
46 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the feat/common-plotter branch May 28, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants