-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adapt to ansys-visualizer #959
Conversation
for more information, see https://pre-commit.ci
…s-geometry into feat/common-plotter
Self reminder: Pyansys visualizer needs to be public before merging this |
@AlejandroFernandezLuces - we need to get this working again |
…s-geometry into feat/common-plotter
…s-geometry into feat/common-plotter
…s-geometry into feat/common-plotter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Just two small comments before approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments - otherwise LGTM
Extracts some common code from the plotter that can be reused in other projects. Extracted code goes to https://github.com/ansys-internal/pyansys-visualizer
Missing: