-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed handling of empty Time Freq Support #996
Conversation
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 88.69% 87.39% -1.30%
==========================================
Files 76 76
Lines 8623 8634 +11
==========================================
- Hits 7648 7546 -102
- Misses 975 1088 +113 |
I reverted as previously said, Also the following code was enough to produce a crash: fields_container = dpf.FieldsContainer()
print(fields_container.time_freq_support)
|
…pf-core into fix/minmax_ent_crash
@cbellot000 @anslpa The new test "test_fields_container_empty_tf_support()" doesn't work with LegacyGrpcServer, not sure on how to proceed from there, as the grpc interface returns an UNAVAILABLE when retrieving a nullptr (which makes sense) |
Completes #967 |
These changes solve the #967 crash, when using fields_container_factory.over_time_freq_fields_container(...)
Edit: this code is wrong.
we should use a dict when we want a TimeFreqSupport
And min_max_* should not be dependent on TimeFreqSupport