Support numpy 2.0 #476
Merged
Support numpy 2.0 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Hi @akaszynski ! Glad to see you here again! It looks good to me!
RobPasMue
reviewed
Aug 19, 2024
Comment on lines
366
to
368
| cdef np.ndarray ndarray | ||
| ndarray = np.array(array_wrapper, copy=False) | ||
| ndarray = np.array(array_wrapper) | ||
|
|
There was a problem hiding this comment.
Couldn't we resolve this based on the numpy version used? Preventing users from using numpy 1.x only for this change seems a bit excessive IMO. Many libraries are still struggling with the switch to numpy 2.X so this might be an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for numpy 2.0 by building with numpy 2.0 and requiring at least numpy 2.0.
Users who've not made the switch can still work with the previous release which will be automatically resolved by pip (as it is, for example, with
matplotlib).