Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabling logging on __del__ #3428

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 23, 2024

Description

Avoid writing to close IO strem when logging using __del__ method.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner September 23, 2024 14:49
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team September 23, 2024 14:49
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Sep 23, 2024
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.10%. Comparing base (2b6dd3f) to head (c5b6654).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3428      +/-   ##
==========================================
- Coverage   85.16%   85.10%   -0.07%     
==========================================
  Files          55       55              
  Lines        9963     9962       -1     
==========================================
- Hits         8485     8478       -7     
- Misses       1478     1484       +6     

@germa89
Copy link
Collaborator Author

germa89 commented Sep 23, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) September 23, 2024 17:07
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 8298793 into main Sep 23, 2024
57 of 59 checks passed
@germa89 germa89 deleted the fix/avoid-IO-error-when-logging-at-exiting branch September 23, 2024 17:07
@germa89 germa89 mentioned this pull request Sep 25, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants