Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: modifying subprocess calls and removing try except continue statements #3474

Merged
merged 92 commits into from
Oct 23, 2024
Merged

refactor: modifying subprocess calls and removing try except continue statements #3474

merged 92 commits into from
Oct 23, 2024

Commits on Jun 19, 2024

  1. fix: update .gitignore file

    @clatapie
    clatapie committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    40d04f6 View commit details
    Browse the repository at this point in the history

  2. fix: fixing minor vulnerabilities

    @clatapie
    clatapie committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    29ad4dc View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'main' into maint/vulnerability_checks

    @clatapie
    clatapie committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7b1058c View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. fix: try/except/pass vulnerabilities

    @clatapie
    clatapie committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9148131 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch maininto maint/vulnerability_checks

    @clatapie
    clatapie committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2bb7123 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'main' into maint/vulnerability_checks

    @clatapie
    clatapie committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a7bc106 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'main' into maint/vulnerability_checks

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d8c56b3 View commit details
    Browse the repository at this point in the history

  2. fix: subprocess calls

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d2734dd View commit details
    Browse the repository at this point in the history

  3. chore: adding changelog file 3474.maintenance.md [dependabot-skip]

    @pyansys-ci-bot
    pyansys-ci-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e920b10 View commit details
    Browse the repository at this point in the history

  4. ci: auto fixes from pre-commit.com hooks. 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    579d41f View commit details
    Browse the repository at this point in the history

  5. fix: test

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3deca3e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'maint/pymapdl_maintenance' of https://github.com/ansys/… 

    …pymapdl into maint/pymapdl_maintenance
    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    410cd2f View commit details
    Browse the repository at this point in the history

  7. ci: auto fixes from pre-commit.com hooks. 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e244650 View commit details
    Browse the repository at this point in the history

  8. chore: adding changelog file 3474.added.md [dependabot-skip]

    @pyansys-ci-bot
    pyansys-ci-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    06af544 View commit details
    Browse the repository at this point in the history

  9. fix: removing pipe in shell command

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cdd479f View commit details
    Browse the repository at this point in the history

  10. ci: auto fixes from pre-commit.com hooks. 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    60b560c View commit details
    Browse the repository at this point in the history

  11. fix: pre-commit

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d0373c8 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'maint/pymapdl_maintenance' of https://github.com/ansys/… 

    …pymapdl into maint/pymapdl_maintenance
    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    123d5fa View commit details
    Browse the repository at this point in the history

  13. test: removing subprocess change

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    82e53b3 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d79c6df View commit details
    Browse the repository at this point in the history

  15. revert: reverting subprocess changes

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cae9462 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'maint/pymapdl_maintenance' of https://github.com/ansys/… 

    …pymapdl into maint/pymapdl_maintenance
    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    283407a View commit details
    Browse the repository at this point in the history

  17. fix: import error

    @clatapie
    clatapie committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1f927bc View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix: import error with minimal requirements

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f519bfe View commit details
    Browse the repository at this point in the history

  2. fix: warning issue

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8f30ec4 View commit details
    Browse the repository at this point in the history

  3. fix: _retrieve_file

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7fb9abf View commit details
    Browse the repository at this point in the history

  4. fix: test_failed_download

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c7270c2 View commit details
    Browse the repository at this point in the history

  5. ci: auto fixes from pre-commit.com hooks. 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    63172ee View commit details
    Browse the repository at this point in the history

  6. fix: test_examples.py

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b07404e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'maint/pymapdl_maintenance' of https://github.com/ansys/… 

    …pymapdl into maint/pymapdl_maintenance
    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2a5d650 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b31af98 View commit details
    Browse the repository at this point in the history

  9. fix: download_examples

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    425bd60 View commit details
    Browse the repository at this point in the history

  10. fix: adding requests in minimum_requirements and reverting ch… 

    …anges in ``_launch`` method
    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9830881 View commit details
    Browse the repository at this point in the history

  11. ci: auto fixes from pre-commit.com hooks. 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    750003b View commit details
    Browse the repository at this point in the history

  12. fix: typo

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5880358 View commit details
    Browse the repository at this point in the history

  13. fix: removing a warning

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5cf1885 View commit details
    Browse the repository at this point in the history

  14. feat: removing shell=True

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8afc259 View commit details
    Browse the repository at this point in the history

  15. fix: attemp to fix the PermissionError

    @clatapie
    clatapie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9e3c559 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7e2c39c View commit details
    Browse the repository at this point in the history

  2. test: providing higher permissions to run the exec file

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    545ee64 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'maint/pymapdl_maintenance' of https://github.com/ansys/… 

    …pymapdl into maint/pymapdl_maintenance
    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8169058 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e1f7b3a View commit details
    Browse the repository at this point in the history

  5. test: using Python 3.12 in CICD for better understanding of the output

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    172d890 View commit details
    Browse the repository at this point in the history

  6. fix: removing " character

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9812f68 View commit details
    Browse the repository at this point in the history

  7. fix: adding ' character

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ab6b7e3 View commit details
    Browse the repository at this point in the history

  8. fix: reverting changes in subprocess

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    23781d2 View commit details
    Browse the repository at this point in the history

  9. fix: checking whether other changes are correct or not

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3f84961 View commit details
    Browse the repository at this point in the history

  10. fix: test__is_ubuntu

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    86218d0 View commit details
    Browse the repository at this point in the history

  11. fix: using executable in subprocess.Popen

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    21fe1fb View commit details
    Browse the repository at this point in the history

  12. fix: proc

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b920a65 View commit details
    Browse the repository at this point in the history

  13. fix: attempt to fix test errors

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bf8cd48 View commit details
    Browse the repository at this point in the history

  14. fix: fix typo

    @clatapie
    clatapie committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5f57e33 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5932bfa View commit details
    Browse the repository at this point in the history

  2. fix: _is_ubuntu

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    87722db View commit details
    Browse the repository at this point in the history

  3. Merge branch 'maint/pymapdl_maintenance' of https://github.com/ansys/… 

    …pymapdl into maint/pymapdl_maintenance
    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    df93a73 View commit details
    Browse the repository at this point in the history

  4. fix: testing another approach for is_ubuntu method

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b6565df View commit details
    Browse the repository at this point in the history

  5. fix: attempt to use shell=False in launch_grpc

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3bc7f7c View commit details
    Browse the repository at this point in the history

  6. fix: removing empty args

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b440434 View commit details
    Browse the repository at this point in the history

  7. test: attempt to fix command_parm

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f60012e View commit details
    Browse the repository at this point in the history

  8. test: attempt to fix command_parm - 2

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f490b90 View commit details
    Browse the repository at this point in the history

  9. ci: auto fixes from pre-commit.com hooks. 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c2e3781 View commit details
    Browse the repository at this point in the history

  10. Update src/ansys/mapdl/core/examples/downloads.py 

    Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
    @clatapie @RobPasMue
    clatapie and RobPasMue authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a94714b View commit details
    Browse the repository at this point in the history

  11. test: attempt to fix command_parm - 3

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    effd48e View commit details
    Browse the repository at this point in the history

  12. fix: call in open_gui

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    53a8dc6 View commit details
    Browse the repository at this point in the history

  13. fix: removing unused variable e

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    31e2e91 View commit details
    Browse the repository at this point in the history

  14. revert: reverting change for MAIN_PYTHON_VERSION

    @clatapie
    clatapie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    247752b View commit details
    Browse the repository at this point in the history

  15. chore: adding changelog file 3474.added.md [dependabot-skip]

    @pyansys-ci-bot
    pyansys-ci-bot committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3b9e847 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    646d6aa View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2bc1915 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: German <28149841+germa89@users.noreply.github.com>
    @clatapie @germa89
    clatapie and germa89 authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    365a74d View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: German <28149841+germa89@users.noreply.github.com>
    @clatapie @germa89
    clatapie and germa89 authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    61cd47d View commit details
    Browse the repository at this point in the history

  4. chore: merge remote-tracking branch 'origin/main' into maint/pymapdl_… 

    …maintenance
    @germa89
    germa89 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c644fb6 View commit details
    Browse the repository at this point in the history

  5. test: fix tests

    @germa89
    germa89 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c751eae View commit details
    Browse the repository at this point in the history

  6. test: reverting change in f'"{exec_file}"'

    @clatapie
    clatapie committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3acc746 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. fix: exec_file errors

    @clatapie
    clatapie committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4e059a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    027bfa5 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. chore: merge remote-tracking branch 'origin/main' into maint/pymapdl_… 

    …maintenance
    @germa89
    germa89 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    41f716e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into maint/pymapdl_maintenance

    @clatapie
    clatapie authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    cbbae17 View commit details
    Browse the repository at this point in the history

  3. review: applying @germa89's suggestions

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    09a9a25 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: German <28149841+germa89@users.noreply.github.com>
    @clatapie @germa89
    clatapie and germa89 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7b846be View commit details
    Browse the repository at this point in the history

  5. review: applying @germa89's suggestions

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    25a9db4 View commit details
    Browse the repository at this point in the history

  6. Update src/ansys/mapdl/core/mapdl_core.py 

    Co-authored-by: German <28149841+germa89@users.noreply.github.com>
    @clatapie @germa89
    clatapie and germa89 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    19cbea9 View commit details
    Browse the repository at this point in the history

  7. review: applying @germa89's suggestions - 2

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2235a19 View commit details
    Browse the repository at this point in the history

  8. fux: using self._log.debug

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4e0688c View commit details
    Browse the repository at this point in the history

  9. fix: test_examples.py

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d845e24 View commit details
    Browse the repository at this point in the history

  10. fix: generate_mapdl_launch_command

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7b857d3 View commit details
    Browse the repository at this point in the history

  11. fix: _checkout_license

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8304fd4 View commit details
    Browse the repository at this point in the history

  12. fix: launch_grpc for Linux

    @clatapie
    clatapie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    52c7b8c View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
    @clatapie @RobPasMue
    clatapie and RobPasMue authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    752f735 View commit details
    Browse the repository at this point in the history

  2. review: applying @germa89 and @RobPasMue's suggestions

    @clatapie
    clatapie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    30aae0a View commit details
    Browse the repository at this point in the history

  3. review: applying code reviewers suggestions

    @clatapie
    clatapie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0ddb90b View commit details
    Browse the repository at this point in the history

  4. fix: using cwd arg in subprocess.call

    @clatapie
    clatapie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a1154bf View commit details
    Browse the repository at this point in the history