Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplifying directory setter property #3517

Merged
merged 20 commits into from
Oct 25, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 25, 2024

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 self-assigned this Oct 25, 2024
@germa89 germa89 requested a review from a team as a code owner October 25, 2024 09:34
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team October 25, 2024 09:34
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Oct 25, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Oct 25, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) October 25, 2024 11:34
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 changed the title feat: simplifying directory setter property refactor: simplifying directory setter property Oct 25, 2024
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.40%. Comparing base (279cbba) to head (521473f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3517      +/-   ##
==========================================
+ Coverage   82.36%   82.40%   +0.04%     
==========================================
  Files          57       58       +1     
  Lines       10004    10017      +13     
==========================================
+ Hits         8240     8255      +15     
+ Misses       1764     1762       -2     

@germa89 germa89 merged commit e63570e into main Oct 25, 2024
56 of 58 checks passed
@germa89 germa89 deleted the refactor--simplyfing-directory-setter branch October 25, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants