Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moving tests to classes to avoid repeated fixtures execution #3523

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 29, 2024

Description

Moving the tests to classes to speed up testing.

Performance

Before

  Time (mean ± σ):     42.118 s ±  5.528 s    [User: 8.025 s, System: 3.524 s]
  Range (min … max):   35.268 s … 53.661 s    10 runs

After

  Time (mean ± σ):     28.822 s ±  7.450 s    [User: 6.949 s, System: 3.077 s]
  Range (min … max):   22.796 s … 43.364 s    10 runs

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner October 29, 2024 10:35
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team October 29, 2024 10:35
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (e63570e) to head (ce97c89).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3523      +/-   ##
==========================================
+ Coverage   82.40%   85.60%   +3.19%     
==========================================
  Files          58       58              
  Lines       10017    12348    +2331     
==========================================
+ Hits         8255    10571    +2316     
- Misses       1762     1777      +15     

@germa89
Copy link
Collaborator Author

germa89 commented Oct 29, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) October 29, 2024 11:35
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 changed the title refactor: moving tests to classes to avoid repeatingly execute the fixtures. refactor: moving tests to classes to avoid repeated fixtures execution Oct 29, 2024
@germa89 germa89 merged commit df9cb3c into main Oct 29, 2024
59 checks passed
@germa89 germa89 deleted the tests/grouping-test_post-under-a-class branch October 29, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants