Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove react native require cycle warning #242

Merged
merged 1 commit into from
Dec 28, 2018

Conversation

jadertao
Copy link
Contributor

fix #236
set the alert,prompt,operation value of component Modal in components/modal/index.tsx instead of components/modal/Modal.tsx to avoid require cycle.

@jadertao jadertao mentioned this pull request Dec 28, 2018
1 task
@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   59.29%   59.29%           
=======================================
  Files         197      197           
  Lines        4936     4936           
  Branches     1082     1082           
=======================================
  Hits         2927     2927           
  Misses       1992     1992           
  Partials       17       17
Flag Coverage Δ
#rn 59.29% <85.71%> (ø) ⬆️
Impacted Files Coverage Δ
components/modal/Modal.tsx 79.77% <0%> (-1.28%) ⬇️
components/modal/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019f68a...293e404. Read the comment docs.

@BANG88 BANG88 merged commit 3467a39 into ant-design:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require cycle
2 participants