Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use call fn to invoke scollView's scrollTo #408

Merged
merged 1 commit into from
Mar 20, 2019
Merged

use call fn to invoke scollView's scrollTo #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/tabs/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export class Tabs extends React.PureComponent<TabsProps, StateType> {
if (this.scrollView && this.scrollView._component) {
const { scrollTo } = this.scrollView._component;
// tslint:disable-next-line:no-unused-expression
scrollTo && scrollTo({ x: offset, animated });
scrollTo && scrollTo.call(this.scrollView._component, { x: offset, animated });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously... 😭

}
}
};
Expand Down