-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configurable toast #911
feat: configurable toast #911
Conversation
onTintColor={color} | ||
trackColor={{ | ||
true: color, | ||
false: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在安卓上测试通过,维持默认颜色
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
晚上我看看
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
==========================================
- Coverage 61.55% 61.31% -0.25%
==========================================
Files 212 212
Lines 5002 5033 +31
Branches 1077 1080 +3
==========================================
+ Hits 3079 3086 +7
- Misses 1906 1930 +24
Partials 17 17
Continue to review full report at Codecov.
|
* @deprecated @param duration | ||
* @deprecated @param onClose | ||
* @deprecated @param mask | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些 deprecated 加不加都行,旧的代码是改不了了。 不过加上也好,只是以后也不会说真的干掉只保留对象的方式.
😄
代码还是写的很棒的,谢谢。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
客气了,这阵子可能还会根据业务需要提一些 issue / pr 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果是急需的就尽快了,要准备发新版了。
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
新增功能
#899
Bug Fix