Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation of NoticeBar #1227

Merged
merged 2 commits into from
Apr 28, 2017
Merged

translation of NoticeBar #1227

merged 2 commits into from
Apr 28, 2017

Conversation

ddcat1115
Copy link
Contributor

@ddcat1115 ddcat1115 force-pushed the Translation-notice-bar branch from 87efc45 to 924abb4 Compare April 27, 2017 13:51
@paranoidjk
Copy link
Contributor

更新一下 snapshot
npm run test:web -- -u

@ddcat1115 ddcat1115 force-pushed the Translation-notice-bar branch from 67639b9 to 0d2a135 Compare April 28, 2017 07:04
@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #1227 into master will decrease coverage by 2.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
- Coverage   69.79%   67.51%   -2.29%     
==========================================
  Files         219      119     -100     
  Lines        4155     2053    -2102     
  Branches     1225      568     -657     
==========================================
- Hits         2900     1386    -1514     
+ Misses       1254      666     -588     
  Partials        1        1
Flag Coverage Δ
#rn ?
#web 67.51% <ø> (ø) ⬆️
Impacted Files Coverage Δ
components/modal/index.tsx
components/search-bar/index.tsx
components/locale-provider/ru_RU.tsx
components/style/themes/default.tsx
components/modal/Modal.tsx
components/warn.tsx
components/modal/AlertContainer.tsx
components/popup/index.tsx
components/popover/index.tsx
components/modal/style/prompt.tsx
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b789a...0d2a135. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 28, 2017 •
edited
Loading

Codecov Report

Merging #1227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1227   +/-   ##
=======================================
  Coverage   69.79%   69.79%           
=======================================
  Files         219      219           
  Lines        4155     4155           
  Branches     1225     1225           
=======================================
  Hits         2900     2900           
  Misses       1254     1254           
  Partials        1        1
Flag Coverage Δ
#rn 72.02% <ø> (ø) ⬆️
#web 67.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a827a1...8d86053. Read the comment docs.

@ddcat1115 ddcat1115 force-pushed the Translation-notice-bar branch from 0d2a135 to e6fda0f Compare April 28, 2017 07:30
paranoidjk
paranoidjk suggested changes Apr 28, 2017
View reviewed changes
components/notice-bar/index.en-US.md Outdated
@@ -4,18 +4,19 @@ type: Data Display
title: NoticeBar
---

在导航栏下方，一般用作系统提醒、活动提醒等通知。
The NoticeBar is aimed for displaying a system message, event notice and etc. Which is under the navigation bar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component to xxxx or use NoticeBar to xx`

we can user other open souce project document as reference, eg https://facebook.github.io/react-native/docs/slider.html

@ddcat1115 ddcat1115 force-pushed the Translation-notice-bar branch from abcda1b to 8d86053 Compare April 28, 2017 08:16
@paranoidjk paranoidjk merged commit 58570de into ant-design:master Apr 28, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
@ddcat1115 @lixiaoyang1992
translation of NoticeBar (ant-design#1227)
7850ba1 
* Translation NoticeBar

* update snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paranoidjk paranoidjk paranoidjk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddcat1115 @paranoidjk