Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Radio #1230

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Conversation

ddcat1115
Copy link
Contributor

@mention-bot
Copy link

@ddcat1115, thanks for your PR! By analyzing the history of the files in this pull request, we identified @warmhug, @pingan1927 and @linfaxin to be potential reviewers.

@paranoidjk
Copy link
Contributor

更新一下 snapshot
npm run test:web -- -u

@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #1230 into master will decrease coverage by 2.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
- Coverage   69.79%   67.51%   -2.29%     
==========================================
  Files         219      119     -100     
  Lines        4155     2053    -2102     
  Branches     1225      568     -657     
==========================================
- Hits         2900     1386    -1514     
+ Misses       1254      666     -588     
  Partials        1        1
Flag Coverage Δ
#rn ?
#web 67.51% <ø> (ø) ⬆️
Impacted Files Coverage Δ
components/table/index.tsx
components/tab-bar/tabbar.android.tsx
components/search-bar/index.tsx
components/pagination/locale/en_US.tsx
components/flex/FlexItem.tsx
components/icon/index.tsx
components/white-space/index.tsx
components/input-item/index.tsx
components/pagination/index.tsx
components/activity-indicator/index.tsx
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b789a...a0f7d2f. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #1230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   69.79%   69.79%           
=======================================
  Files         219      219           
  Lines        4155     4155           
  Branches     1225     1225           
=======================================
  Hits         2900     2900           
  Misses       1254     1254           
  Partials        1        1
Flag Coverage Δ
#rn 72.02% <ø> (ø) ⬆️
#web 67.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b789a...a0f7d2f. Read the comment docs.

@paranoidjk
Copy link
Contributor

提交 PR 的时候应该尽量把 snapshot 的更新单独做一个 commit,便于 code review。

cc @ant-design/ant-design-team

@paranoidjk paranoidjk merged commit b2ed5fb into ant-design:master Apr 28, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants