Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable mako #11326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: enable mako #11326

wants to merge 1 commit into from

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 30, 2024

https://umijs.org/docs/api/config#mako

https://makojs.dev/

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration option for enhanced development using the mako framework.
  • Bug Fixes

    • Removed outdated mfsu configuration to streamline the build process.
  • Chores

    • Simplified proxy configuration by removing unnecessary properties.

Copy link

coderabbitai bot commented Aug 30, 2024

Walkthrough

The changes involve the removal of the mfsu configuration option and the introduction of a new mako option in the config/config.ts file, indicating a shift in the development framework. Additionally, the mako property has been removed from the config/proxy.ts file, simplifying the proxy configuration. These modifications reflect a reorganization in the project's build strategy and proxy settings.

Changes

Files Change Summary
config/config.ts Removed mfsu configuration; added mako configuration for rapid development.
config/proxy.ts Removed mako property from the default export object, simplifying configuration.

Poem

In the meadow, changes spry,
Mako hops, and mfsu says goodbye.
A new path for the builders bright,
With every leap, we take flight.
Hooray for the shifts, let’s cheer and play,
For progress blooms in a joyful way! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Aug 30, 2024

🎊 PR Preview has been successfully built and deployed to https://ant-design-pro-preview-pr-11326.surge.sh

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3e59c41 and 4228e80.

Files selected for processing (2)
  • config/config.ts (2 hunks)
  • config/proxy.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • config/proxy.ts
Additional comments not posted (1)
config/config.ts (1)

150-155: Verify the completeness of the mako configuration.

The addition of the mako configuration aligns with the PR objectives to enable rapid development using the Mako framework. However, the configuration block is empty. Please verify if this is intentional or if additional parameters are required for optimal integration.

The code changes are approved.

Consider verifying the completeness of the mako configuration by consulting the Mako documentation or relevant project requirements.

Comment on lines +150 to +155
/**
* @name 是否开启 mako
* @description 使用 mako 极速研发
* @doc https://umijs.org/docs/api/config#mako
*/
mako: {},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assess the impact of removing mfsu.

The removal of the mfsu configuration option marks a significant change in the project's build strategy. It is crucial to assess the impact of this change on the build performance and ensure that all dependencies and project requirements are still being met.

Consider conducting a thorough impact analysis to verify that the removal of mfsu does not adversely affect the project's build process or performance.

@afc163
Copy link
Member Author

afc163 commented Aug 30, 2024

windows 还不支持。@sorrycc @stormslowly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant