Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Anchor className should pass down. #14248

Merged
merged 1 commit into from
Jan 10, 2019
Merged

feat: Anchor className should pass down. #14248

merged 1 commit into from
Jan 10, 2019

Conversation

ycjcl868
Copy link
Contributor

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

image

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Jan 10, 2019

Deploy preview for ant-design ready!

Built with commit 791b06e

https://deploy-preview-14248--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #14248 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14248   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         325      325           
  Lines        7097     7097           
  Branches     1781     1752   -29     
=======================================
  Hits         6684     6684           
  Misses        401      401           
  Partials       12       12
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929418f...791b06e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 10, 2019 •
edited
Loading

Codecov Report

Merging #14248 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14248   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         325      325           
  Lines        7097     7097           
  Branches     1781     1752   -29     
=======================================
  Hits         6684     6684           
  Misses        401      401           
  Partials       12       12
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929418f...791b06e. Read the comment docs.

@chenshuai2144
Copy link
Contributor

chenshuai2144 commented Jan 10, 2019 via email

@ycjcl868
Copy link
Contributor Author

@chenshuai2144 What?

@afc163 afc163 merged commit 22a4ca8 into master Jan 10, 2019
@afc163 afc163 deleted the enhance-anchorLink branch January 10, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenshuai2144 chenshuai2144 Awaiting requested review from chenshuai2144

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycjcl868 @chenshuai2144 @afc163