Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing defaultFormat #14593

Merged
merged 1 commit into from
Jan 28, 2019
Merged

add missing defaultFormat #14593

merged 1 commit into from
Jan 28, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 28, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Miss default datePicker dateTime format:
2019-01-28 1 54 27

Changelog description (Optional if not new feature)

  1. Add missing DatePicker dateTime default format
  2. 增加 DatePicker 的 dateTime 格式。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #14593 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14593      +/-   ##
==========================================
- Coverage   94.43%   94.41%   -0.03%     
==========================================
  Files         333      333              
  Lines        7264     7265       +1     
  Branches     1788     1823      +35     
==========================================
- Hits         6860     6859       -1     
- Misses        389      391       +2     
  Partials       15       15
Impacted Files Coverage Δ
components/date-picker/wrapPicker.tsx 100% <ø> (ø) ⬆️
components/upload/UploadList.tsx 88.03% <0%> (-1.71%) ⬇️
components/form/Form.tsx 94.11% <0%> (ø) ⬆️
components/menu/SubMenu.tsx 92.85% <0%> (ø) ⬆️
components/input/TextArea.tsx 82.85% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5de5f4c...7f1042b. Read the comment docs.

@zombieJ zombieJ merged commit a379c47 into master Jan 28, 2019
@zombieJ zombieJ deleted the date-picker-time branch January 28, 2019 06:07
@netlify
Copy link

netlify bot commented Jan 28, 2019

Deploy preview for ant-design ready!

Built with commit 7f1042b

https://deploy-preview-14593--ant-design.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants