-
-
Notifications
You must be signed in to change notification settings - Fork 49.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support customize separator #15055
support customize separator #15055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
readonly="" | ||
tabindex="-1" | ||
value="" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
readonly="" | ||
tabindex="-1" | ||
value="" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
@@ -122,6 +122,7 @@ The following APIs are shared by DatePicker, MonthPicker, RangePicker, WeekPicke | |||
| format | to set the date format | string | "YYYY-MM-DD HH:mm:ss" | | |||
| ranges | preseted ranges for quick selection | { \[range: string]: [moment](http://momentjs.com/)\[] } \| { \[range: string]: () => [moment](http://momentjs.com/)\[] } | - | | |||
| renderExtraFooter | render extra footer in panel | () => React.ReactNode | - | | |||
| separator | (Add in 3.14.0) set separator between inputs | string | '~' | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
版本信息加一列吧。#14818
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加的一列叫 Version
| 版本
以节约列宽度。
Deploy preview for ant-design ready! Built with commit 20d6749 |
Codecov Report
@@ Coverage Diff @@
## feature #15055 +/- ##
========================================
Coverage 93.08% 93.08%
========================================
Files 247 247
Lines 6635 6635
Branches 1920 1920
========================================
Hits 6176 6176
Misses 458 458
Partials 1 1
Continue to review full report at Codecov.
|
调了一下,再看看~ |
typescript prop does not work. |
@Brlja More detail information? |
I get an error that property "separator" does not exist. Using the latest version. Twice checked. |
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
close #9891
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Popup style will change with input & separator line.
Changelog description (Optional if not new feature)
Self Check before Merge