Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13648 #15056

Merged
merged 4 commits into from
Feb 26, 2019
Merged

fix #13648 #15056

merged 4 commits into from
Feb 26, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Feb 26, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

fix #13648

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for ant-design ready!

Built with commit d5a8a3a

https://deploy-preview-15056--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #15056 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15056   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         236      236           
  Lines        6256     6256           
  Branches     1871     1839   -32     
=======================================
  Hits         5804     5804           
- Misses        449      451    +2     
+ Partials        3        1    -2
Impacted Files Coverage Δ
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a802a72...d5a8a3a. Read the comment docs.

@yoyo837
Copy link
Contributor Author

yoyo837 commented Feb 26, 2019

could not find a copy of typescript to link in /Users/tanghui/git/github/ant-design/node_modules/antd-tools/node_modules

本地跑不了lint, 眯着眼睛蒙了.

@zombieJ
Copy link
Member

zombieJ commented Feb 26, 2019

直接加个 left & top 就行了吧?
2019-02-26 4 24 54

@yoyo837
Copy link
Contributor Author

yoyo837 commented Feb 26, 2019

@zombieJ 你的更好,我改一下。

@zombieJ
Copy link
Member

zombieJ commented Feb 26, 2019

另外,style lint 错误你可以通过 npm run lint-fix:style 来修复哈~

@yoyo837
Copy link
Contributor Author

yoyo837 commented Feb 26, 2019

你家ant-design依赖安装不上,scripts用不了,所以靠蒙。

@zombieJ
Copy link
Member

zombieJ commented Feb 26, 2019

你家ant-design依赖安装不上,scripts用不了,所以靠蒙。

是网络问题吗?可以试试 cnpm or taobao 镜像

@zombieJ zombieJ merged commit 9e8bddd into ant-design:master Feb 26, 2019
@yoyo837
Copy link
Contributor Author

yoyo837 commented Feb 26, 2019

目前就是淘宝源,报 #15056 (comment) ,cnpm找机会试一试。

@yoyo837 yoyo837 deleted the fix-13648 branch February 26, 2019 09:13
@orzyyyy orzyyyy mentioned this pull request Mar 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spin wrapperClassName 设置 padding 图标不居中
2 participants