-
-
Notifications
You must be signed in to change notification settings - Fork 49.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Empty component again #15487
Conversation
@zombieJ 先 review 实现吧,可以的话我再把 测试/demo 改了。 |
Deploy preview for ant-design ready! Built with commit 780e51b |
ImageType 这个名字是否需要改成 EmptyImage |
Codecov Report
@@ Coverage Diff @@
## feature #15487 +/- ##
===========================================
- Coverage 94.14% 94.1% -0.04%
===========================================
Files 250 250
Lines 6643 6637 -6
Branches 1931 1940 +9
===========================================
- Hits 6254 6246 -8
- Misses 388 390 +2
Partials 1 1
Continue to review full report at Codecov.
|
用 base64 ? 现在还是 feature 分支,图片地址改了。不方便用 GitHub 的图片 或者干脆删了这一段?反正下面的 demo 里面已经写了 |
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
Describe the source of requirement, like related issue link.
Describe the problem and the scenario.
💡 Solution
How to fix the problem, and list final API implementation and usage sample if that is an new feature.
GIF or snapshot should be provided if includes UI/interactive modification.
📝 Changelog description
English description
Chinese description (optional)
☑️ Self Check before Merge