Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty missing when Table is loading #15583

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix empty missing when Table is loading #15583

merged 1 commit into from
Mar 22, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #15582

💡 Solution

现在用了 Empty 之后,#9069 就会有点问题,我把这个改动回滚掉。

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
  1. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 requested a review from zombieJ March 22, 2019 04:29
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #15583 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15583      +/-   ##
==========================================
- Coverage   94.45%   94.45%   -0.01%     
==========================================
  Files         250      250              
  Lines        6650     6649       -1     
  Branches     1946     1910      -36     
==========================================
- Hits         6281     6280       -1     
  Misses        368      368              
  Partials        1        1
Impacted Files Coverage Δ
components/table/Table.tsx 92.96% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d7d7f...c67fdb6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #15583 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15583      +/-   ##
==========================================
- Coverage   94.45%   94.45%   -0.01%     
==========================================
  Files         250      250              
  Lines        6650     6649       -1     
  Branches     1946     1910      -36     
==========================================
- Hits         6281     6280       -1     
  Misses        368      368              
  Partials        1        1
Impacted Files Coverage Δ
components/table/Table.tsx 92.96% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d7d7f...c67fdb6. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 22, 2019

Deploy preview for ant-design ready!

Built with commit c67fdb6

https://deploy-preview-15583--ant-design.netlify.com

@zombieJ zombieJ merged commit 9e0aa5c into master Mar 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-table-empty branch March 22, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table missing Empty render when loading is true
3 participants