Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Feature merge master #16798

Merged
merged 3 commits into from
May 26, 2019
Merged

chore: Feature merge master #16798

merged 3 commits into from
May 26, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

View rendered components/calendar/demo/customize-header.md
View rendered components/calendar/index.en-US.md
View rendered components/calendar/index.zh-CN.md
View rendered components/slider/index.en-US.md
View rendered components/slider/index.zh-CN.md

abgaryanharutyun and others added 3 commits May 26, 2019 13:09
* added new calendar api, renderHeader now we can customize calendar header

* fixed typo for tests

* error handling for renderHeader

* covering all cases with tests

* fixed tests and change console error to warning

* fixed feedbacks and code optimization

* cleanup callback function arguments

* removed unused changes

* fixed tests

* added extra classes

* fixed some comments

* tying to fix test for remote

* tying to fix test for remote in my local machin it works fine

* tying to fix test for remote in my local machin it works fine

* tying to fix test for remote in my local machin it works fine

* updated test snapshots

* fixed comment

* fixed linting

* fixed some texts

* added header for CN and added argument types

* removed extra row
@netlify
Copy link

netlify bot commented May 26, 2019

Deploy preview for ant-design ready!

Built with commit 3493cc1

https://deploy-preview-16798--ant-design.netlify.com

@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #16798 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16798      +/-   ##
==========================================
+ Coverage   95.78%   95.83%   +0.05%     
==========================================
  Files         263      263              
  Lines        7300     7316      +16     
  Branches     2038     2005      -33     
==========================================
+ Hits         6992     7011      +19     
+ Misses        306      303       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/calendar/index.tsx 96.73% <ø> (ø) ⬆️
components/calendar/Header.tsx 96.84% <100%> (+0.59%) ⬆️
components/slider/index.tsx 89.18% <100%> (+0.3%) ⬆️
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9793e30...3493cc1. Read the comment docs.

@zombieJ zombieJ merged commit a3e19ce into master May 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature-merge-master branch May 26, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants