fix: Should TimePicker defaultOpenValue work #21198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9200671:
|
Codecov Report
@@ Coverage Diff @@
## master #21198 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 296 296
Lines 6918 6918
Branches 1873 1873
=======================================
Hits 6745 6745
Misses 173 173Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix #21153
💡 Background and solution
🤖 Though we add this prop back, but removed from official doc since this prop is little confused for user understand current value status.
📝 Changelog
defaultOpenValuenot work and remove this from doc since it may confuse user for current value status.☑️ Self Check before Merge
View rendered components/time-picker/index.en-US.md
View rendered components/time-picker/index.zh-CN.md