Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when user doesn't pass icon props to message.open #21747

Merged
merged 1 commit into from
Mar 2, 2020
Merged

fix: crash when user doesn't pass icon props to message.open #21747

merged 1 commit into from
Mar 2, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Mar 2, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#21745

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix crash when the user doesn't pass icon props to message.open
🇨🇳 Chinese 修复了message.open中icon为空的时候报错

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

tests-checker[bot]
tests-checker bot suggested changes Mar 2, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 2, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cfa23ab:

Sandbox Source
antd reproduction template Configuration

@yoyo837 yoyo837 merged commit 5993fc3 into ant-design:master Mar 2, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 2, 2020
@yoyo837 yoyo837 mentioned this pull request Mar 2, 2020
Closed
1 task
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 left review comments

@tests-checker tests-checker tests-checker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshoneA @ant-design-bot @yoyo837