Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: fix form item with feedback in rtl #22222

Merged
merged 1 commit into from
Mar 15, 2020
Merged

style: fix form item with feedback in rtl #22222

merged 1 commit into from
Mar 15, 2020

Conversation

saeedrahimi
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22218

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@saeedrahimi saeedrahimi changed the title fix form item in rtl Fix: form item in rtl Mar 15, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 15, 2020 •
edited
Loading

@saeedrahimi saeedrahimi changed the title Fix: form item in rtl style: fix form item with feedback in rtl Mar 15, 2020
@codecov
Copy link

codecov bot commented Mar 15, 2020 •
edited
Loading

Codecov Report

Merging #22222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22222   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7042     7042           
  Branches     1939     1938    -1     
=======================================
  Hits         6899     6899           
  Misses        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50c42c...67c8e59. Read the comment docs.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 10bf25e403c7995a05d051272e69b11e17415ab4:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 67c8e59:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 merged commit c52d25d into master Mar 15, 2020
@afc163 afc163 deleted the fix-form-feedback-rtl branch March 15, 2020 11:20
@afc163 afc163 mentioned this pull request Mar 15, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Closed
This was referenced Mar 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg Awaiting requested review from xrkffgg

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL form fields with feedback
3 participants
@saeedrahimi @ant-design-bot @afc163