Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: replace deprecated React.SFC with React.FunctionComponent #22691

Merged
merged 2 commits into from
Mar 28, 2020
Merged

refactoring: replace deprecated React.SFC with React.FunctionComponent #22691

merged 2 commits into from
Mar 28, 2020

Conversation

Rustin170506
Copy link
Contributor

@Rustin170506 Rustin170506 commented Mar 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

None

💡 Background and solution

DefinitelyTyped/DefinitelyTyped#30364

📝 Changelog

Language Changelog
🇺🇸 English replace deprecated React.SFC with React.FunctionComponent
🇨🇳 Chinese 更新弃用的 React.SFC 为 React.FunctionComponent

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 28, 2020

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #22691 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22691      +/-   ##
==========================================
+ Coverage   98.14%   98.14%   +<.01%     
==========================================
  Files         306      306              
  Lines        7078     7079       +1     
  Branches     1900     1945      +45     
==========================================
+ Hits         6947     6948       +1     
  Misses        131      131
Impacted Files Coverage Δ
components/result/index.tsx 100% <ø> (ø) ⬆️
components/button/button-group.tsx 100% <100%> (ø) ⬆️
components/statistic/Number.tsx 100% <100%> (ø) ⬆️
components/card/Grid.tsx 100% <100%> (ø) ⬆️
components/config-provider/context.tsx 100% <100%> (ø) ⬆️
components/card/Meta.tsx 100% <100%> (ø) ⬆️
components/divider/index.tsx 100% <100%> (ø) ⬆️
components/progress/Line.tsx 100% <100%> (ø) ⬆️
components/timeline/TimelineItem.tsx 91.66% <100%> (ø) ⬆️
components/descriptions/Item.tsx 50% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e38928...9eee0ef. Read the comment docs.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1805a6e:

Sandbox Source
antd reproduction template Configuration

@Rustin170506 Rustin170506 requested a review from afc163 March 28, 2020 03:46
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9eee0ef:

Sandbox Source
antd reproduction template Configuration

@Rustin170506
Copy link
Contributor Author

@afc163 CI broken because the size changed. Other tests all passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants