Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve less variable @form-item-margin-bottom #23436

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 21, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#21302 (comment)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form fields shake when @form-item-margin-bottom is customize and switching the validing info.
🇨🇳 Chinese 修复 Form 自定义 @form-item-margin-bottom 变量时表单校验抖动的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 21, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 655038a:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

afc163 commented Apr 21, 2020

当@form-item-margin-bottom变量不大于0时隐藏核验信息

需要写解决了什么问题。

@yoyo837
Copy link
Contributor Author

yoyo837 commented Apr 21, 2020

当@form-item-margin-bottom变量不大于0时隐藏核验信息

需要写解决了什么问题。

改了下看行不行。

@yoyo837 yoyo837 changed the title chore: improve @formItemMarginBottom chore: improve less variable @form-item-margin-bottom Apr 21, 2020
@afc163
Copy link
Member

afc163 commented Apr 21, 2020

changelog 可以写:修复 Form 自定义 @form-item-margin-bottom 变量时表单校验抖动的问题。

@afc163
Copy link
Member

afc163 commented Apr 21, 2020

英文 changelog 补一下。

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #23436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23436   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         364      364           
  Lines        7315     7315           
  Branches     1957     2004   +47     
=======================================
  Hits         7204     7204           
  Misses        111      111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e206b41...655038a. Read the comment docs.

@yoyo837
Copy link
Contributor Author

yoyo837 commented Apr 21, 2020

英文 changelog 补一下。

Done.

@afc163 afc163 merged commit 17c63e5 into master Apr 21, 2020
@afc163 afc163 deleted the imporove-less-form-item-margin-bottom branch April 21, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants