Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip in Upload components location error #24001

Merged
merged 1 commit into from
May 9, 2020

Conversation

mraiguo
Copy link
Contributor

@mraiguo mraiguo commented May 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#23997

💡 Background and solution

Tooltip in Upload components is having problems with its location on Modal

📝 Changelog

Language Changelog
🇺🇸 English 修复组件 Upload在浮层中错误提示滚动定位问题
🇨🇳 Chinese Fix Upload error message location to scroll in the float layer

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 9, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c66f10e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #24001 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24001   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7272     7274    +2     
  Branches     2027     1981   -46     
=======================================
+ Hits         7183     7185    +2     
  Misses         89       89           
Impacted Files Coverage Δ
components/upload/UploadList.tsx 99.24% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0f12c...c66f10e. Read the comment docs.

@afc163 afc163 merged commit 28f7192 into ant-design:master May 9, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants