Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export RuleObject and RuleRender types from Form #24541

Merged
merged 3 commits into from
May 30, 2020
Merged

chore: export RuleObject and RuleRender types from Form #24541

merged 3 commits into from
May 30, 2020

Conversation

sorteam
Copy link
Contributor

@sorteam sorteam commented May 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Types are needed to declare validation functions separately as RuleRender:

const myValidator: RuleRender = (form) => ({...});

📝 Changelog

Language Changelog
🇺🇸 English Add: export RuleObject and RuleRender types from Form
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 28, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 28, 2020 •
edited
Loading

@afc163 afc163 requested a review from zombieJ May 28, 2020 14:03
@zombieJ zombieJ changed the title Added: export RuleObject and RuleRender types from Form chore: export RuleObject and RuleRender types from Form May 30, 2020
@zombieJ
Copy link
Member

zombieJ commented May 30, 2020

/rebase

@zombieJ zombieJ merged commit d8d4848 into ant-design:master May 30, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorteam @ant-design-bot @zombieJ