fix: remove content max-width on dot-step #24907

07akioni · 2020-06-11T05:46:51Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

Removing the max-width on dot step.

📝 Changelog

Language	Changelog
🇺🇸 English	Remove the 140px width limit on vertical dot Steps.Step.
🇨🇳 Chinese	移除了垂直点状 Steps.Step 的 140px 宽度限制。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

ant-design-bot · 2020-06-11T05:50:15Z

ant-design-bot · 2020-06-11T05:50:21Z

afc163 · 2020-06-11T05:59:57Z

解决什么问题。

codesandbox-ci · 2020-06-11T06:02:04Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd24197:

Sandbox	Source
antd reproduction template	Configuration

codecov · 2020-06-11T06:04:49Z

Codecov Report

Merging #24907 into feature will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           feature   #24907   +/-   ##
========================================
  Coverage    99.33%   99.33%           
========================================
  Files          369      369           
  Lines         7367     7367           
  Branches      2012     2061   +49     
========================================
  Hits          7318     7318           
  Misses          49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa6c0a1...cd24197. Read the comment docs.

zombieJ · 2020-06-11T08:19:03Z

垂直 dot 样式占了整宽但是展示区域只有 140px

zombieJ · 2020-06-11T10:47:05Z

components/steps/style/progress-dot.less

@@ -47,9 +47,6 @@
        }
      }
    }
-    &-content {
-      width: @steps-desciption-max-width;


这个 less 变量还有用不？没用的话主题里也删了。

这个还有用

对横着的 dot 还有影响

afc163 · 2020-06-12T07:33:41Z

移除了垂直点状 Steps.Step 的 140px 宽度限制。

重新写一下。

* feat: add successColor for Progress (#24655) * feat: add successColor for Progress * feat: update * fix: update test * remove snap * feat: add test case * refactor success * feat: adjust styyle * feat: add DevWarning * feat: Support rowSelection.dirty (#24718) * feat: Support rowSelection.dirty * rename to reserveKeys * preserveKeys will keep record also * to preserveSelectedRowKeys * feat: add ghost prop for collapse (#24734) * feat: add ghost prop for collapse * doc: version of collapse's ghost prop * refactor: make ghost collapse's less code to a nested style * chore: remove redundant codes in ghost collapse's less & doc * doc: add a background wrapper for ghost collapse demo * doc: dark-theme wrapper bg-color for ghost collapse demo * test: update snapshot of ghost collapse * doc: use softer bg-color on ghost collapse demo * doc: remove disabled panel in ghost collapse demo * feat: form instance support getFieldInstance (#24711) * support getFieldInstance * update doc * fix lint * move func * move into hooks * update ref logic * fix lint * rm only * fix docs * feat: dropdown support arrow (#23869) * feat: dropdown support arrow prop close #22758 * test: update snapshot * fix: fix dropdown cls names * test: update snapshot * test: update snapshot * doc: update demo * test: update demo snapshot * demo * fix: snapshot * chore: change the style of ghost collapse & demo modified (#24762) * refactor: reduce content padding in ghost collapse * doc: remove the wrapper outside ghost collapse Designer want the demo differs from other demos * refactor: remove redundant .less code in collapse * feat: cascader dropdown-render prop (#24812) * feat: cascader dropdown-render prop * fix: update Cascader dropdownRender type annotation * fix: set rc-cascader semver from ^ to ~ * docs: fix coding style in cascader/custom-dropdown * feat: 🆕 support Drawer closeIcon (#24842) * feat: 🆕 support Drawer closeIcon close #19283 close #19153 * add test case * update docs * feat: 🆕 Cascader expandIcon (#24865) * feat: cascader expandIcon * fix: snap * refactor: reduce CSS size (#24846) * refactor: reduce button css size * refactor: remove redundant button .less code * feat: add Table onChange an action param (#24697) * Working on tests * created TableAction type * changed TableActions to tuple * removed chinese documentation line * refactor TableActions * fix documentation * Moved action into extra param * minor doc change * feat: add closeIcon customize tag close (#24885) * feat: add closeIcon customize tag close * docs fix * update snap * fix: css name * update snapshot * snapshot * feat: add radio `optionType` api to set radio option type (#24809) * feat: radio component * docs: update md * fix: snap * test components * fix: use optionType * fix name * add warning * fix * feat: expand rate character (#24903) * feat: expand rate character * fix: demo * fix: snap * Update components/rate/index.zh-CN.md Co-authored-by: 偏右 <afc163@gmail.com> * fix Co-authored-by: 偏右 <afc163@gmail.com> * Refactor demo code box actions (#24887) * refactor: refine the styling of actions part of demo code-box * fix: lint style * refactor: move Result children to end (#24945) * feat: remove content max-width on dot-step (#24907) * feat: add Skeleton-Image (#24805) * feat: add Skeleton-Image * feat: add docs * fix: adjust skeleton * feat: adjust Image Component * feat: rebase * feat: adjust style * fix: lint * feat: remove size * feat: delete md * feat: fix style * ✨ feat: Mentions support autoSize (#24961) close #17746 * chore: replace textarea with rc-textarea (#24966) * feat: update pagination@2.3.0 support onChange called when pageSize change (#24964) * feat: update pagination@2.5.0 and add test case to relative component * fix: lint * delete * feat: add test case for pagination * adjust test case * feat: Implement centered prop in Tabs (#24958) * Implement centered in Tabs along with its tests and docs * Fix build error * Add Chinese translations and remove test case Co-authored-by: Ashkan Pourghasem <ashkan.pourghasem@gmail.com> * feat: Add modal style parameter (#24773) * add some paramters in default.less * Update components/style/themes/default.less Co-authored-by: Amumu <yoyo837@hotmail.com> * change parameter in compact.less Co-authored-by: Crystal Gao <jinggao@ebay.com> Co-authored-by: Amumu <yoyo837@hotmail.com> * feat: export Tabs addIcon (#25006) * feat: export Tabs addIcon * update snapshot * feat: showNow on timepicker and datetimepicker (#25032) * feat: update rc-picker@1.7.1 and fix icons of month and quarter picker in DatePicker Component (#25035) * feat: update rc-picker@1.7.1 * delete * add * feat: expand rate support props (#24993) * docs: 📝 Add Form.Item hidden in doc (#25108) close #25101 * fix: ⌨️ Improve Pagination accessibility issue (#25119) * ⌨️ Improve Pagination a11y by fixing a W3C error react-component/pagination#280 * update snapshot * 🆙 rc-pagination to 2.4.1 * feat: support triggerSubMenuAction for <Menu /> (#25127) * feat(menu): add triggerSubMenuAction for Menu * feat(menu): test cases * chore: Adjust picker logic (#25135) * chore: update rc-picker 1.10.0 (#25174) * feat: table row check strictly (#24931) * feat: add checkStrictly on Table.rowSelection * fix: LGTM warnings * test: table rowSelection.checkStrictly * test: add cov [wip] * refactor: tree.rowSelection.checkStrictly [wip] * test: table.rowSelection.checkStrictly basic case * feat: support rowKey on checkStrictly table * feat: Table checkStrictly support getCheckboxProps * docs: Table checkStrictly * chore: typo * chore: remove useless comment * chore: update snapshot * chore: update snapshot * fix: fire selectAll on selection dropdown menu & changeRows incorrect in selectAll callback * docs: typo * chore * chore * fix: expand buttons of leaf rows in tree data are not hidden * feat: Table warning about rowKey index parameter * perf: only generate keyEntities when not checkStrictly * refactor: remove useless parseCheckedKeys * refactor: get derived selected & half selected keys from selectedRowKeys * chore: remove env condition stmt * chore: revert index usage & code formatting * chore: rerun ci * docs: table tree-data checkstrictly * test: update snapshots * refactor: use useMergedState hook * chore: rerun ci * chore: rerun ci 2 * chore: revert selection select all behavior * refactor: refactor code based on feature * chore: revert table code format * chore: revert table code format * fix: useMemo deps * fix: useMemo deps * fix: useMemo deps * feat: support preserve (#25186) * docs: add responsibly order for Col (#25139) * feat: add type * feat: add responsibly order cols * feat: add docs * feat: add test case * fix test Co-authored-by: 二货机器人 <smith3816@gmail.com> Co-authored-by: 偏右 <afc163@gmail.com> Co-authored-by: zoomdong <1344492820@qq.com> Co-authored-by: 07akioni <07akioni2@gmail.com> Co-authored-by: wendellhu <wendellhu95@gmail.com> Co-authored-by: xrkffgg <xrkffgg@gmail.com> Co-authored-by: Neto Braghetto <netow93@gmail.com> Co-authored-by: Kermit Xuan <kermitlx@outlook.com> Co-authored-by: Ashkan Pourghasem <64011067+ashkan-pm@users.noreply.github.com> Co-authored-by: Ashkan Pourghasem <ashkan.pourghasem@gmail.com> Co-authored-by: hicrystal <295247343@qq.com> Co-authored-by: Crystal Gao <jinggao@ebay.com> Co-authored-by: Amumu <yoyo837@hotmail.com> Co-authored-by: Li Ming <armyiljfe@gmail.com>

This reverts commit 0879bd5.

…27406) * chore: code style * Revert "feat: remove content max-width on dot-step (#24907)" This reverts commit 0879bd5. * chore: revert code style

feat: remove content max-width on dot-step

cd24197

pr-triage bot added the PR: unreviewed label Jun 11, 2020

zombieJ reviewed Jun 11, 2020

View reviewed changes

zombieJ approved these changes Jun 12, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jun 12, 2020

zombieJ merged commit 0879bd5 into feature Jun 12, 2020

zombieJ deleted the feat-steps-width branch June 12, 2020 07:02

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jun 12, 2020

afc163 changed the title ~~feat: remove content max-width on dot-step~~ fix: remove content max-width on dot-step Jun 12, 2020

chenshuai2144 mentioned this pull request Jun 29, 2020

docs: add 4.4.0 changelog #25242

Merged

13 tasks

yoyo837 mentioned this pull request Oct 27, 2020

4.x版本中步骤条样式不居中 #27405

Closed

1 task

yoyo837 added a commit that referenced this pull request Oct 27, 2020

Revert "feat: remove content max-width on dot-step (#24907)"

04c4636

This reverts commit 0879bd5.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove content max-width on dot-step #24907

fix: remove content max-width on dot-step #24907

07akioni commented Jun 11, 2020

ant-design-bot commented Jun 11, 2020 •

edited

Loading

ant-design-bot commented Jun 11, 2020 •

edited

Loading

afc163 commented Jun 11, 2020

codesandbox-ci bot commented Jun 11, 2020

codecov bot commented Jun 11, 2020 •

edited

Loading

zombieJ commented Jun 11, 2020

zombieJ Jun 11, 2020

07akioni Jun 12, 2020

07akioni Jun 12, 2020

afc163 commented Jun 12, 2020 •

edited

Loading

fix: remove content max-width on dot-step #24907

fix: remove content max-width on dot-step #24907

Conversation

07akioni commented Jun 11, 2020

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

ant-design-bot commented Jun 11, 2020 • edited Loading

ant-design-bot commented Jun 11, 2020 • edited Loading

afc163 commented Jun 11, 2020

codesandbox-ci bot commented Jun 11, 2020

codecov bot commented Jun 11, 2020 • edited Loading

Codecov Report

zombieJ commented Jun 11, 2020

zombieJ Jun 11, 2020

Choose a reason for hiding this comment

07akioni Jun 12, 2020

Choose a reason for hiding this comment

07akioni Jun 12, 2020

Choose a reason for hiding this comment

afc163 commented Jun 12, 2020 • edited Loading

ant-design-bot commented Jun 11, 2020 •

edited

Loading

ant-design-bot commented Jun 11, 2020 •

edited

Loading

codecov bot commented Jun 11, 2020 •

edited

Loading

afc163 commented Jun 12, 2020 •

edited

Loading