Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: optimize dropdown rtl style #26206

Merged
merged 1 commit into from
Aug 14, 2020
Merged

style: optimize dropdown rtl style #26206

merged 1 commit into from
Aug 14, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 14, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize Dropdown RTL writing to avoid dark mode style overlays.
🇨🇳 Chinese 优化 Dropdown RTL 写法避免暗黑模式样式覆盖。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 14, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 14, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8457d79:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #26206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26206   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         373      373           
  Lines        7315     7315           
  Branches     2040     1992   -48     
=======================================
  Hits         7282     7282           
  Misses         33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6763b3...8457d79. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +9 B (0%)

Total Size: 803 kB

Filename Size Change
./dist/antd.compact.min.css 64.9 kB +3 B (0%)
./dist/antd.dark.min.css 66.1 kB +3 B (0%)
./dist/antd.min.css 64.9 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 319 kB 0 B
./dist/antd.min.js 288 kB 0 B

compressed-size-action

@xrkffgg xrkffgg merged commit 49d02a0 into master Aug 14, 2020
@xrkffgg xrkffgg deleted the opt-dropdown-rtl branch August 14, 2020 07:41
@pr-triage pr-triage bot added the PR: merged label Aug 14, 2020
@zombieJ zombieJ mentioned this pull request Aug 22, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants