Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Modal missing modalRender prop #27272

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Fix Modal missing modalRender prop #27272

merged 2 commits into from
Oct 30, 2020

Conversation

jieny
Copy link
Contributor

@jieny jieny commented Oct 21, 2020

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 重构
  • 功能增强
  • 国际化改进
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#27174

💡 需求背景和解决方案

支持Modal拖拽

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文 Fix Modal missing modalRender prop
🇨🇳 中文 修复 Modal modalRender 属性定义

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

add 【modalRender?: (node: React.ReactNode) => React.ReactNode;】
添加modalRender方便扩展和支持拖拽
@afc163

This comment has been minimized.

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 21, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 21, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 88d998c:

Sandbox Source
antd reproduction template Configuration

@hengkx
Copy link
Member

hengkx commented Oct 22, 2020

rebase master and check ci

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #27272 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7389      7389           
  Branches      2067      2025   -42     
=========================================
  Hits          7389      7389           
Impacted Files Coverage Δ
components/modal/ConfirmDialog.tsx 100.00% <ø> (ø)
components/modal/Modal.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0822ac6...88d998c. Read the comment docs.

@afc163 afc163 merged commit 9052af4 into ant-design:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants