Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input[allowClear] className #27462

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 30, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27444
close #27258

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input missing className when allowClear is true.
🇨🇳 Chinese 修复 Input allowClearclassName 丢失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 30, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 103b12a:

Sandbox Source
antd reproduction template Configuration
antd-issue-repro-custom-classes-clearable-input Issue #27444

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #27462 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27462   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7383      7385    +2     
  Branches      2075      2069    -6     
=========================================
+ Hits          7383      7385    +2     
Impacted Files Coverage Δ
components/input/ClearableLabeledInput.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa95f58...103b12a. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +37 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +16 B (0%)
./dist/antd.min.js 277 kB +21 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.5 kB 0 B
./dist/antd.dark.min.css 67.8 kB 0 B
./dist/antd.min.css 66.5 kB 0 B

compressed-size-action

@afc163 afc163 merged commit 39e37bf into master Oct 30, 2020
@afc163 afc163 deleted the fix-input-allowclear-classname branch October 30, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass custom className to clearable input Input.Search 显示不全
2 participants