-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace BackTop with rc-motion #27840
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 65b1c2f:
|
Codecov Report
@@ Coverage Diff @@
## master #27840 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 389 389
Lines 7374 7373 -1
Branches 2043 2042 -1
=========================================
- Hits 7374 7373 -1
Continue to review full report at Codecov.
|
Size Change: +76 B (0%) Total Size: 789 kB
ℹ️ View Unchanged
|
{({ className: motionClassName }) => { | ||
const childNode = children || defaultElement; | ||
return ( | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这一层 div 是必须的么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原本的 rc-animate
配置了 component="div"
,这边迁移先做保留。
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
rc-motion
instead ofrc-animate
.rc-animate
代替rc-motion
。☑️ Self Check before Merge