Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when target not an html element #29523

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

bcd337
Copy link
Contributor

@bcd337 bcd337 commented Feb 26, 2021

fix error when target is object but not an html element

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix BackTop/Anchor throws error when target don't return a html element.
🇨🇳 Chinese 修复 BackTop/Anchor target 不是 html 元素时会出错问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

fix error when target is object but not an html element
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2021

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #29523 (a0da33d) into master (4d3b2d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7480      7480           
  Branches      2106      2106           
=========================================
  Hits          7480      7480           
Impacted Files Coverage Δ
components/_util/getScroll.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3b2d8...58b2a84. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants