You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Popconfirm API docs the type of the type of the props okButtonProps and cancelButtonProps is ButtonProps. In the actual code however it is was typed as NativeButtonProps causing type errors when using ButtonProps like href
To solve this issue, the types of okButtonProps and cancelButtonProps have been changed to ButtonProps
📝 Changelog
Language
Changelog
🇺🇸 English
Fix type error in Popconfirm
🇨🇳 Chinese
修复Popconfirm中的类型错误
☑️ Self Check before Merge
⚠️ Please check all items below before review. ⚠️
Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
According to the Popconfirm API docs the type of the type of the props okButtonProps and cancelButtonProps is ButtonProps In the actual code however it is was typed as NativeButtonProps causing type errors when using ButtonProps like 'href'
❗ Current head 463f24a differs from pull request most recent head d5a71cc. Consider uploading reports for the commit d5a71cc to get more accurate results
Cl -> Changelog? I think that happened because i didn't fill out the Chinese part and that's also because can't speak Chinese. Can you help out?
No, Some checks were not successful. Pls fix them.
IggsGrey
changed the title
Change type of Popconfirm props: okButtonProps to ButtonProps
fix: Change type of Popconfirm props: okButtonProps to ButtonProps
Mar 30, 2021
…nt-design#29928)
* Change type of Popconfirm props: okButtonProps to ButtonProps
According to the Popconfirm API docs the type of the type of the props okButtonProps and cancelButtonProps is ButtonProps In the actual code however it is was typed as NativeButtonProps causing type errors when using ButtonProps like 'href'
* fix: Remove unused NativeButtonProps
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IggsGrey
changed the title
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
According to the
PopconfirmAPI docs the type of the type of the propsokButtonPropsandcancelButtonPropsisButtonProps.In the actual code however it is was typed asNativeButtonPropscausing type errors when usingButtonPropslikehrefTo solve this issue, the types of
okButtonPropsandcancelButtonPropshave been changed toButtonProps📝 Changelog
☑️ Self Check before Merge