fix(FormItem): add name as default variables.label value #30179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #30179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 397 397
Lines 7519 7563 +44
Branches 2105 2128 +23
=========================================
+ Hits 7519 7563 +44
Continue to review full report at Codecov.
|
zombieJ
reviewed
Jun 1, 2021
| @@ -265,6 +265,8 @@ function FormItem<Values = any>(props: FormItemProps<Values>): React.ReactElemen | |||
| let variables: Record<string, string> = {}; | |||
| if (typeof label === 'string') { | |||
| variables.label = label; | |||
| } else if (name) { | |||
| variables.label = String(name); | |||
There was a problem hiding this comment.
Could you help to add a test case about this?
There was a problem hiding this comment.
Ok, I will add the test case as soon as possible ~
yingpengsha
pushed a commit
to yingpengsha/ant-design
that referenced
this pull request
Jul 2, 2021
…30179) * fix(FormItem): add name as default variables.label value * test(Form.Item): add name as default test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Fix #30146. When
labelis not given,${label}will be replaced byundefined. I think we could addnameas a defaultvariables.labelvalue.💡 Background and solution
📝 Changelog
nameas a default label value invalidationMessages.name作为验证消息label的默认值☑️ Self Check before Merge