Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InputNumber support null #30337

Merged
merged 2 commits into from
Apr 28, 2021
Merged

fix: InputNumber support null #30337

merged 2 commits into from
Apr 28, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 28, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #30096

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English InputNumber clean up input will trigger onChange(null) now.
🇨🇳 Chinese InputNumber 现在清空输入框时会触发 onChange(null)

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021

Size Change: +6 B (0%)

Total Size: 830 kB

Filename Size Change
./dist/antd.compact.min.css 63.9 kB +2 B (0%)
./dist/antd.dark.min.css 65.2 kB +2 B (0%)
./dist/antd.min.css 63.9 kB +1 B (0%)
./dist/antd.min.js 298 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 339 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #30337 (355c9bb) into master (7e0af50) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7522      7522           
  Branches      2105      2105           
=========================================
  Hits          7522      7522           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0af50...355c9bb. Read the comment docs.

@zombieJ zombieJ merged commit dbbf0da into master Apr 28, 2021
@zombieJ zombieJ deleted the input-number branch April 28, 2021 05:55
@zombieJ zombieJ mentioned this pull request Apr 30, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onChange not firing when InputNumber changes
1 participant