Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: redesign Table header action #30651

Merged
merged 13 commits into from
May 24, 2021
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 24, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

图片

before ✅ after
图片 图片
before ✅ after
图片 图片

📝 Changelog

Language Changelog
🇺🇸 English Redesign Table filter and sorter buttons to clarify current column.
🇨🇳 Chinese 重新设计 Table 筛选和排序按钮的位置,使其归属列更明确。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the base branch from master to feature May 24, 2021 11:05
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2021

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2021

Size Change: -221 B (0%)

Total Size: 845 kB

Filename Size Change
./dist/antd-with-locales.min.js 348 kB -34 B (0%)
./dist/antd.compact.min.css 63.9 kB -62 B (0%)
./dist/antd.dark.min.css 65.2 kB -44 B (0%)
./dist/antd.min.css 64 kB -48 B (0%)
./dist/antd.min.js 304 kB -33 B (0%)

compressed-size-action

@afc163 afc163 changed the base branch from feature to master May 24, 2021 12:39
@afc163
Copy link
Member Author

afc163 commented May 24, 2021

直接发到 master 好了。

@afc163
Copy link
Member Author

afc163 commented May 24, 2021

@afc163 afc163 force-pushed the redesign-table-header-action branch from d83b416 to 3a372ee Compare May 24, 2021 13:38
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #30651 (31cf953) into master (352c560) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7544      7544           
  Branches      2112      2112           
=========================================
  Hits          7544      7544           
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 100.00% <100.00%> (ø)
components/table/hooks/useSorter.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352c560...31cf953. Read the comment docs.

afc163 referenced this pull request in react-component/table May 24, 2021
* fix: customize scrollbar size should not break

* fix: Test case
@afc163 afc163 mentioned this pull request May 24, 2021
19 tasks
@afc163 afc163 merged commit 082f626 into master May 24, 2021
@afc163 afc163 deleted the redesign-table-header-action branch May 24, 2021 14:16
@zombieJ zombieJ mentioned this pull request May 24, 2021
19 tasks
@nuintun
Copy link
Contributor

nuintun commented May 25, 2021

@afc163 @zombieJ 居中居右对齐现在很丑

image

@303394539
Copy link
Contributor

@afc163 这个before在没有排序等元素的时候还显示出来很显眼,与title的位置对比起来比较别扭

@xyuanbuilds
Copy link
Contributor

@afc163 @zombieJ 居中居右对齐现在很丑

image

这,我强迫症犯了

@u1in
Copy link

u1in commented Nov 15, 2021

希望before平时能够隐藏或者能够有api隐藏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants