Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Progress type="circle" error #30855

Merged
merged 4 commits into from
Jun 5, 2021
Merged

fix: Progress type="circle" error #30855

merged 4 commits into from
Jun 5, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 4, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30685

💡 Background and solution

Rendered more hooks than during the previous render

📝 Changelog

Language Changelog
🇺🇸 English Fix Progress type="circle" throws error Rendered more hooks than during the previous render sometimes.
🇨🇳 Chinese 修复 Progress type="circle" 有时会报错 Rendered more hooks than during the previous render 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

Size Change: -86 B (0%)

Total Size: 830 kB

Filename Size Change
./dist/antd-with-locales.min.js 340 kB -32 B (0%)
./dist/antd.min.js 297 kB -54 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.9 kB 0 B
./dist/antd.dark.min.css 65.2 kB 0 B
./dist/antd.min.css 64.1 kB 0 B

compressed-size-action

`Rendered more hooks than during the previous render`

close #30685
@afc163 afc163 force-pushed the fix-progress-success branch from b818d4a to ab9f413 Compare June 4, 2021 08:29
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #30855 (f734217) into master (618dc62) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30855   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7551      7571   +20     
  Branches      2118      2126    +8     
=========================================
+ Hits          7551      7571   +20     
Impacted Files Coverage Δ
components/progress/Circle.tsx 100.00% <100.00%> (ø)
components/progress/progress.tsx 100.00% <100.00%> (ø)
components/typography/util.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618dc62...f734217. Read the comment docs.

@afc163
Copy link
Member Author

afc163 commented Jun 4, 2021

@afc163 afc163 merged commit ad60e95 into master Jun 5, 2021
@afc163 afc163 deleted the fix-progress-success branch June 5, 2021 05:25
@zombieJ zombieJ mentioned this pull request Jun 7, 2021
15 tasks
@ghost ghost mentioned this pull request Apr 19, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use circle progress with success percent got "Rendered more hooks than during the previous render."
1 participant